chore: Merge some rbac files, move some functions around #6916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
I think this is an improvement, but I think we could go even further with this. Thoughts on:
- The primary file in this folder being named
rbac.goas a clear entrypoint. - The primary file containing commonly edited actions like default role permissions being named
roles.go(I know it already is, just restating that this is great). - Merge
cache.go,authz.go, andbuiltin.gointo a single file. I feel like they all circulate around being the same, even if they aren't exactly the same conceptually.
|
I prefer keeping them different files, but we have precedent for just making larger
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.