Skip to content

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 31, 2023

Workspace proxies currently do nothing, this is just the DB crud side

Fixes: #6906

Future work

More fields to be added.

@Emyrk Emyrk marked this pull request as ready for review March 31, 2023 16:27
@Emyrk Emyrk requested a review from deansheather April 3, 2023 15:51
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I don't understand why moons are org-scoped when they're a thing done at the deployment level. Only site owners should be able to add moons and they should be deployment-scoped and work for any workspace in any org.

@Emyrk Emyrk merged commit b4afbe7 into main Apr 4, 2023
@Emyrk Emyrk deleted the stevenmasley/moon_crud branch April 4, 2023 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moon CRUD
2 participants