Skip to content

feat: tolerate disconnects in agent metadata frontend #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2023
Merged

feat: tolerate disconnects in agent metadata frontend #6939

merged 3 commits into from
Apr 7, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Mar 31, 2023 •
edited
Loading

No description provided.

@ammario ammario self-assigned this Mar 31, 2023
@ammario ammario requested a review from kylecarbs March 31, 2023 22:24
@ammario ammario enabled auto-merge (squash) March 31, 2023 22:24
@ammario ammario changed the title agent tolerate feat: tolerate disconnects in agent metadata frontend Mar 31, 2023
@ammario
Copy link
Member Author

ammario commented Mar 31, 2023

@kylecarbs — not 100% sure if it's safe to call setTimeout like that.

@ammario ammario disabled auto-merge March 31, 2023 22:31
@ammario
Copy link
Member Author

ammario commented Mar 31, 2023

An alternate approach is described here. Not sure which is better.

@ammario ammario merged commit dd85ea8 into main Apr 7, 2023
@ammario ammario deleted the agent-tolerate branch April 7, 2023 00:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @kylecarbs