fix(agent): prevent goroutine pile up in reportMetadataLoop #6957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the prior implementation, calls to DoChan would stack up because we weren't updating lastCollectedAts until collectMetadata finished. This wasn't a true leak, instead, it meant that there would be up to ~ (collectionRuntime / baseInterval) outstanding goroutines. So, for example, if `sleep 60s` was the metadata script there would be up to 60 goroutines waiting at peak.
kylecarbs
approved these changes
Apr 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the prior implementation, calls to DoChan would stack up because we
weren't updating lastCollectedAts until collectMetadata finished. This
wasn't a true leak, instead, it meant that there would be
up to ~ (collectionRuntime / baseInterval) outstanding goroutines. So, for
example, if
sleep 60swas the metadata script there would be up to60 goroutines waiting at peak.
The new implementation has a simplistic singeflight where calls to
Dowill immediately return instead of blocking.