Get the flow

coder · BrunoQuaresma · Apr 4, 2023 · Apr 3, 2023 · Apr 3, 2023 · Apr 3, 2023
commit c12558f24bd59bad03fb64ef5ebd1300be3e689d
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -1,4 +1,4 @@
-import axios, { AxiosRequestHeaders } from "axios"
+import axios from "axios"
 import dayjs from "dayjs"
 import * as Types from "./types"
 import { DeploymentConfig } from "./types"
@@ -64,7 +64,7 @@ if (token !== null && token.getAttribute("content") !== null) {
   }
 }
 
-const CONTENT_TYPE_JSON: AxiosRequestHeaders = {
+const CONTENT_TYPE_JSON = {
   "Content-Type": "application/json",
 }
 
@@ -974,6 +974,41 @@ export class MissingBuildParameters extends Error {
   }
 }
 
+/** Steps to change the workspace version
+ * - Get the latest template to access the latest active version
+ * - Get the current build parameters
+ * - Get the template parameters
+ * - Update the build parameters and check if there are missed parameters for the new version
+ *   - If there are missing parameters raise an error
+ * - Create a build with the version and updated build parameters
+ */
+export const changeWorkspaceVersion = async (
+  workspace: TypesGen.Workspace,
+  templateVersionId: string,
+  newBuildParameters: TypesGen.WorkspaceBuildParameter[] = [],
+): Promise<TypesGen.WorkspaceBuild> => {
+  const [currentBuildParameters, templateParameters] = await Promise.all([
+    getWorkspaceBuildParameters(workspace.latest_build.id),
+    getTemplateVersionRichParameters(templateVersionId),
+  ])
+
+  const missingParameters = getMissingParameters(
+    currentBuildParameters,
+    newBuildParameters,
+    templateParameters,
+  )
+
+  if (missingParameters.length > 0) {
+    throw new MissingBuildParameters(missingParameters)
+  }
+
+  return postWorkspaceBuild(workspace.id, {
+    transition: "start",
+    template_version_id: templateVersionId,
+    rich_parameter_values: newBuildParameters,
+  })
+}
+
 /** Steps to update the workspace
  * - Get the latest template to access the latest active version
  * - Get the current build parameters

diff --git a/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx b/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
@@ -182,9 +182,12 @@ export const WorkspaceReadyPage = ({
         onClose={() => {
           setChangeVersionDialogOpen(false)
         }}
-        onConfirm={() => {
+        onConfirm={(templateVersion) => {
           setChangeVersionDialogOpen(false)
-          workspaceSend({ type: "CHANGE_VERSION" })
+          workspaceSend({
+            type: "CHANGE_VERSION",
+            templateVersionId: templateVersion.id,
+          })
         }}
       />
     </>

diff --git a/site/src/xServices/workspace/workspaceXService.ts b/site/src/xServices/workspace/workspaceXService.ts
@@ -80,6 +80,8 @@ export interface WorkspaceContext {
   createBuildLogLevel?: TypesGen.CreateWorkspaceBuildRequest["log_level"]
   // SSH Config
   sshPrefix?: string
+  // Change version
+  templateVersionIdToChange?: TypesGen.TemplateVersion["id"]
 }
 
 export type WorkspaceEvent =
@@ -90,6 +92,11 @@ export type WorkspaceEvent =
   | { type: "DELETE" }
   | { type: "CANCEL_DELETE" }
   | { type: "UPDATE"; buildParameters?: TypesGen.WorkspaceBuildParameter[] }
+  | {
+      type: "CHANGE_VERSION"
+      templateVersionId: TypesGen.TemplateVersion["id"]
+      buildParameters?: TypesGen.WorkspaceBuildParameter[]
+    }
   | { type: "CANCEL" }
   | {
       type: "REFRESH_TIMELINE"
@@ -157,6 +164,9 @@ export const workspaceMachine = createMachine(
         updateWorkspace: {
           data: TypesGen.WorkspaceBuild
         }
+        changeWorkspaceVersion: {
+          data: TypesGen.WorkspaceBuild
+        }
         startWorkspace: {
           data: TypesGen.WorkspaceBuild
         }
@@ -290,6 +300,10 @@ export const workspaceMachine = createMachine(
                   STOP: "requestingStop",
                   ASK_DELETE: "askingDelete",
                   UPDATE: "requestingUpdate",
+                  CHANGE_VERSION: {
+                    target: "requestingChangeVersion",
+                    actions: ["assignTemplateVersionIdToChange"],
+                  },
                   CANCEL: "requestingCancel",
                   RETRY_BUILD: [
                     {
@@ -341,10 +355,37 @@ export const workspaceMachine = createMachine(
                   ],
                 },
               },
+              requestingChangeVersion: {
+                entry: ["clearBuildError"],
+                invoke: {
+                  src: "changeWorkspaceVersion",
+                  onDone: {
+                    target: "idle",
+                    actions: ["assignBuild", "clearTemplateVersionIdToChange"],
+                  },
+                  onError: [
+                    {
+                      target: "askingForMissedBuildParameters",
+                      cond: "isMissingBuildParameterError",
+                      actions: ["assignMissedParameters"],
+                    },
+                    {
+                      target: "idle",
+                      actions: ["assignBuildError"],
+                    },
+                  ],
+                },
+              },
               askingForMissedBuildParameters: {
                 on: {
                   CANCEL: "idle",
-                  UPDATE: "requestingUpdate",
+                  UPDATE: [
+                    {
+                      target: "requestingChangeVersion",
+                      cond: "isChangingVersion",
+                    },
+                    { target: "requestingUpdate" },
+                  ],
                 },
               },
               requestingStart: {
@@ -669,6 +710,14 @@ export const workspaceMachine = createMachine(
       // Debug mode when build fails
       enableDebugMode: assign({ createBuildLogLevel: (_) => "debug" as const }),
       disableDebugMode: assign({ createBuildLogLevel: (_) => undefined }),
+      // Change version
+      assignTemplateVersionIdToChange: assign({
+        templateVersionIdToChange: (_, { templateVersionId }) =>
+          templateVersionId,
+      }),
+      clearTemplateVersionIdToChange: assign({
+        templateVersionIdToChange: (_) => undefined,
+      }),
     },
     guards: {
       moreBuildsAvailable,
@@ -684,6 +733,8 @@ export const workspaceMachine = createMachine(
       lastBuildWasDeleting: ({ workspace }) => {
         return workspace?.latest_build.transition === "delete"
       },
+      isChangingVersion: ({ templateVersionIdToChange }) =>
+        Boolean(templateVersionIdToChange),
     },
     services: {
       getWorkspace: async ({ username, workspaceName }) => {
@@ -708,6 +759,23 @@ export const workspaceMachine = createMachine(
           send({ type: "REFRESH_TIMELINE" })
           return build
         },
+      changeWorkspaceVersion:
+        ({ workspace, templateVersionIdToChange }, { buildParameters }) =>
+        async (send) => {
+          if (!workspace) {
+            throw new Error("Workspace is not set")
+          }
+          if (!templateVersionIdToChange) {
+            throw new Error("Template version id to change is not set")
+          }
+          const build = await API.changeWorkspaceVersion(
+            workspace,
+            templateVersionIdToChange,
+            buildParameters,
+          )
+          send({ type: "REFRESH_TIMELINE" })
+          return build
+        },
       startWorkspace: (context) => async (send) => {
         if (context.workspace) {
           const startWorkspacePromise = await API.startWorkspace(