refactor: Refactor FormTextField to not require a HoC #70
+56
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kylecarbs
approved these changes
Jan 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 71.09% 70.90% -0.19%
==========================================
Files 82 82
Lines 3376 3372 -4
Branches 49 49
==========================================
- Hits 2400 2391 -9
- Misses 770 774 +4
- Partials 206 207 +1
Continue to review full report at Codecov.
|
|
Thanks for the idea @kylecarbs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted from discussion here: https://github.com/coder/coder/pull/60/files#r792124373
Our current FormTextField implementation requires a higher-order component, which can be complicated to understand.
This experiments with moving it to not require being a HoC.
The only difference in usage is that sometimes, you need to provide the type like
<FormTextField<FormValues> form={form} formFieldName="some-field-in-form" />- but it doesn't require special construction.