Skip to content

feat: accept immutable parameters when used first time #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 4, 2023

Related: #6941

This PR improves the backend side of Coder to accept immutable parameters when they are used for the first time.

@mtojek mtojek requested review from BrunoQuaresma and bpmct April 4, 2023 10:50
@mtojek mtojek self-assigned this Apr 4, 2023
@mtojek mtojek marked this pull request as ready for review April 4, 2023 11:31
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Tests ❤️

@mtojek mtojek merged commit 083fc89 into coder:main Apr 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants