Skip to content

fix(site): Prompting user for missing variables #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2023
Merged

fix(site): Prompting user for missing variables #7002

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b623b24
Ask for new immutable parameteers
BrunoQuaresma Apr 3, 2023
ae50531
Merge branch 'main' into bq/fix-immutable-parameters
BrunoQuaresma Apr 4, 2023
63a840a
Fix tests
BrunoQuaresma Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 4, 2023
commit 63a840a73dfc18080272f04e1295b28059b88df3
2 changes: 1 addition & 1 deletion site/src/api/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ describe("api.ts", () => {

expect(error).toBeInstanceOf(api.MissingBuildParameters)
// Verify if the correct missing parameters are being passed
// It should not require immutable parameters
expect((error as api.MissingBuildParameters).parameters).toEqual([
MockTemplateVersionParameter1,
{ ...MockTemplateVersionParameter2, mutable: false },
])
})

Expand Down