Skip to content

chore: add agent metadata to example templates #7044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 12, 2023
Merged

chore: add agent metadata to example templates #7044

merged 10 commits into from
Apr 12, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Apr 7, 2023

This PR adds agent metadata to Linux-based example templates.
contributes #6829

@matifali matifali changed the title add Agent Metadata chore: add agent metadata to example templates Apr 7, 2023
@matifali
Copy link
Member Author

matifali commented Apr 7, 2023

@ammario for review.
I have used top -bn1 and test the agent metadata scripts locally on a Linux machine

Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — see comment on docker cpu/mem

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this doesn't address Docker/Kubernetes, can you change it to "contributes to #6829"?

@bpmct bpmct merged commit 264093a into coder:main Apr 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
@matifali matifali deleted the template-agent-metadata branch April 12, 2023 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants