Skip to content

refactor(site): Refactor workspace schedule page #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 11, 2023
Merged

refactor(site): Refactor workspace schedule page #7069

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
19306ce
Add base workspace settings layout
BrunoQuaresma Apr 10, 2023
4b2a964
Update layout
BrunoQuaresma Apr 10, 2023
29cd7aa
Fix sidebar link
BrunoQuaresma Apr 10, 2023
d8f128d
Fix cancel link
BrunoQuaresma Apr 10, 2023
bda21b2
Improve data loading
BrunoQuaresma Apr 10, 2023
e249b3e
Apply suggestions from code review
BrunoQuaresma Apr 11, 2023
4784181
Update site/src/components/WorkspaceScheduleForm/WorkspaceScheduleFor…
BrunoQuaresma Apr 11, 2023
a10774f
Merge branch 'main' into bq/refactor-workspace-settings
BrunoQuaresma Apr 11, 2023
b338fe1
Fix tests
BrunoQuaresma Apr 11, 2023
1b8ec42
Merge branch 'bq/refactor-workspace-settings' of https://github.com/c…
BrunoQuaresma Apr 11, 2023
8b1b291
Remove helper text
BrunoQuaresma Apr 11, 2023
bfec2fb
Merge branch 'main' into bq/refactor-workspace-settings
BrunoQuaresma Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix cancel link
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 10, 2023
commit d8f128d16dc7b4aded55df4740ed1496da43e189
2 changes: 1 addition & 1 deletion site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const WorkspaceSettingsPage = () => {
isLoading={isLoading}
isSubmitting={updateSettings.isLoading}
settings={settings}
onCancel={() => navigate(-1)}
onCancel={() => navigate(`/@${username}/${workspaceName}`)}
onSubmit={updateSettings.mutate}
/>
</>
Expand Down