Skip to content

fix(site): Load monaco locally #7092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2023
Merged

fix(site): Load monaco locally #7092

merged 3 commits into from
Apr 14, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #7091

@BrunoQuaresma BrunoQuaresma requested review from kylecarbs and a team April 11, 2023 17:55
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 11, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team April 11, 2023 17:55
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 11, 2023 17:56
Kira-Pilot
Kira-Pilot approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to best test this but the code looks clean!

@BrunoQuaresma BrunoQuaresma merged commit ad665ce into main Apr 14, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-monaco-cdn branch April 14, 2023 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monaco editor pulls from CDN
2 participants
@BrunoQuaresma @Kira-Pilot