Skip to content

feat(site): Ask for missing template variables in the template editor #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2023
Merged

feat(site): Ask for missing template variables in the template editor #7108

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b446a79
Improve build error message
BrunoQuaresma Apr 12, 2023
5d150ee
Add bases
BrunoQuaresma Apr 12, 2023
06014f5
Fix
BrunoQuaresma Apr 12, 2023
9cd893f
Fix dirty
BrunoQuaresma Apr 12, 2023
5af343d
Merge branch 'main' into bq/prompt-template-variables
BrunoQuaresma Apr 14, 2023
fdf0896
Fix default variable values
BrunoQuaresma Apr 14, 2023
8d83af3
Disable autocoomplete for variable input
BrunoQuaresma Apr 14, 2023
e25b59c
Merge branch 'main' into bq/prompt-template-variables
BrunoQuaresma Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix default variable values
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Apr 14, 2023
commit fdf0896126e9640db039c872e3897ccf4fd33d3f
12 changes: 11 additions & 1 deletion site/src/components/TemplateVersionEditor/MissingTemplateVariablesDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import DialogContent from "@material-ui/core/DialogContent"
import DialogContentText from "@material-ui/core/DialogContentText"
import DialogTitle from "@material-ui/core/DialogTitle"
import { DialogProps } from "components/Dialogs/Dialog"
import { FC, useState } from "react"
import { FC, useEffect, useState } from "react"
import { FormFields, VerticalForm } from "components/Form/Form"
import { TemplateVersionVariable, VariableValue } from "api/typesGenerated"
import DialogActions from "@material-ui/core/DialogActions"
Expand All @@ -27,6 +27,16 @@ export const MissingTemplateVariablesDialog: FC<
const styles = useStyles()
const [variableValues, setVariableValues] = useState<VariableValue[]>([])

// Pre-fill the form with the default values when missing variables are loaded
useEffect(() => {
if (!missingVariables) {
return
}
setVariableValues(
missingVariables.map((v) => ({ name: v.name, value: v.value })),
)
}, [missingVariables])

return (
<Dialog
{...dialogProps}
Expand Down