Skip to content

refactor(site): Refactor workspace actions #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma requested a review from a team April 13, 2023 16:42
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 13, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team April 13, 2023 16:42
@matifali
Copy link
Member

Why to show both start, and stop when only 1 of them can be clicked at a time? What about using the same position and change it to start or stop depending on the workspace condition.

Start if workspace is stopped
Stop if workspace is starting
Disable if state is starting or deleting

@BrunoQuaresma
Copy link
Collaborator Author

@matifali in this case is showing both because it is in the failed state. More info: #6468

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 14, 2023 14:33
@BrunoQuaresma BrunoQuaresma merged commit 7bbbb91 into main Apr 14, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-workspace-header branch April 14, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: clicking delete workspace does not respond
3 participants