Fix

coder · BrunoQuaresma · Apr 13, 2023 · Apr 12, 2023 · Apr 13, 2023 · Apr 13, 2023
commit c4072abe757631304b4a16b3e46c1849928e2b35
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -636,6 +636,7 @@ jobs:
         uses: chromaui/action@v1
         env:
           NODE_OPTIONS: "--max_old_space_size=4096"
+          STORYBOOK: true
         with:
           buildScriptName: "storybook:build"
           exitOnceUploaded: true
@@ -655,6 +656,7 @@ jobs:
         uses: chromaui/action@v1
         env:
           NODE_OPTIONS: "--max_old_space_size=4096"
+          STORYBOOK: true
         with:
           autoAcceptChanges: true
           buildScriptName: "storybook:build"

diff --git a/site/package.json b/site/package.json
@@ -17,7 +17,7 @@
     "lint:fix": "FIX=true yarn lint",
     "playwright:install": "playwright install --with-deps chromium",
     "playwright:test": "playwright test --config=e2e/playwright.config.ts",
-    "storybook": "storybook dev -p 6006",
+    "storybook": "STORYBOOK=true storybook dev -p 6006",
     "storybook:build": "storybook build",
     "test": "jest --selectProjects test",
     "test:ci": "jest --selectProjects test --silent",

diff --git a/site/src/components/Dialogs/ConfirmDialog/ConfirmDialog.stories.tsx b/site/src/components/Dialogs/ConfirmDialog/ConfirmDialog.stories.tsx
@@ -6,22 +6,16 @@ export default {
   title: "Components/Dialogs/ConfirmDialog",
   component: ConfirmDialog,
   argTypes: {
-    onClose: {
-      action: "onClose",
-      defaultValue: action("onClose"),
-    },
-    onConfirm: {
-      action: "onConfirm",
-      defaultValue: action("onConfirm"),
-    },
     open: {
       control: "boolean",
-      defaultValue: true,
-    },
-    title: {
-      defaultValue: "Confirm Dialog",
     },
   },
+  args: {
+    onClose: action("onClose"),
+    onConfirm: action("onConfirm"),
+    open: true,
+    title: "Confirm Dialog",
+  },
 } as ComponentMeta<typeof ConfirmDialog>
 
 const Template: Story<ConfirmDialogProps> = (args) => (

diff --git a/site/src/components/Dialogs/DeleteDialog/DeleteDialog.stories.tsx b/site/src/components/Dialogs/DeleteDialog/DeleteDialog.stories.tsx
@@ -6,29 +6,18 @@ export default {
   title: "Components/Dialogs/DeleteDialog",
   component: DeleteDialog,
   argTypes: {
-    onCancel: {
-      action: "onClose",
-      defaultValue: action("onClose"),
-    },
-    onConfirm: {
-      action: "onConfirm",
-      defaultValue: action("onConfirm"),
-    },
     open: {
       control: "boolean",
-      defaultValue: true,
-    },
-    entity: {
-      defaultValue: "foo",
-    },
-    name: {
-      defaultValue: "MyFoo",
-    },
-    info: {
-      defaultValue:
-        "Here's some info about the foo so you know you're deleting the right one.",
     },
   },
+  args: {
+    onCancel: action("onClose"),
+    onConfirm: action("onConfirm"),
+    open: true,
+    entity: "foo",
+    name: "MyFoo",
+    info: "Here's some info about the foo so you know you're deleting the right one.",
+  },
 } as ComponentMeta<typeof DeleteDialog>
 
 const Template: Story<DeleteDialogProps> = (args) => <DeleteDialog {...args} />

diff --git a/site/src/components/LoadingButton/LoadingButton.stories.tsx b/site/src/components/LoadingButton/LoadingButton.stories.tsx
@@ -5,8 +5,11 @@ export default {
   title: "components/LoadingButton",
   component: LoadingButton,
   argTypes: {
-    loading: { control: { type: "boolean" } },
-    children: { control: "text", defaultValue: "Create workspace" },
+    loading: { control: "boolean" },
+    children: { control: "text" },
+  },
+  args: {
+    children: "Create workspace",
   },
 }
 

diff --git a/site/src/components/Resources/AgentRow.tsx b/site/src/components/Resources/AgentRow.tsx
@@ -73,7 +73,6 @@ export const AgentRow: FC<AgentRowProps> = ({
 }) => {
   const styles = useStyles()
   const { t } = useTranslation("agent")
-
   const [logsMachine, sendLogsEvent] = useMachine(workspaceAgentLogsMachine, {
     context: { agentID: agent.id },
     services: process.env.STORYBOOK

diff --git a/site/src/components/SearchBarWithFilter/SearchBarWithFilter.stories.tsx b/site/src/components/SearchBarWithFilter/SearchBarWithFilter.stories.tsx
@@ -1,4 +1,4 @@
-import { ComponentMeta, Story } from "@storybook/react"
+import { Story } from "@storybook/react"
 import { userFilterQuery, workspaceFilterQuery } from "../../utils/filters"
 import {
   SearchBarWithFilter,
@@ -8,12 +8,10 @@ import {
 export default {
   title: "components/SearchBarWithFilter",
   component: SearchBarWithFilter,
-  argTypes: {
-    filter: {
-      defaultValue: workspaceFilterQuery.me,
-    },
+  args: {
+    filter: workspaceFilterQuery.me,
   },
-} as ComponentMeta<typeof SearchBarWithFilter>
+}
 
 const Template: Story<SearchBarWithFilterProps> = (args) => (
   <SearchBarWithFilter {...args} />

diff --git a/site/src/components/VersionsTable/VersionsTable.stories.tsx b/site/src/components/VersionsTable/VersionsTable.stories.tsx
@@ -24,6 +24,7 @@ Example.args = {
     },
     MockTemplateVersion,
   ],
+  onPromoteClick: undefined,
 }
 
 export const CanPromote = Template.bind({})

diff --git a/site/src/components/WorkspaceSchedule/WorkspaceSchedule.stories.tsx b/site/src/components/WorkspaceSchedule/WorkspaceSchedule.stories.tsx
@@ -9,10 +9,8 @@ dayjs.extend(utc)
 export default {
   title: "components/WorkspaceSchedule",
   component: WorkspaceSchedule,
-  argTypes: {
-    canUpdateWorkspace: {
-      defaultValue: true,
-    },
+  args: {
+    canUpdateWorkspace: true,
   },
 }
 

diff --git a/site/src/pages/CliAuthPage/CliAuthPageView.stories.tsx b/site/src/pages/CliAuthPage/CliAuthPageView.stories.tsx
@@ -5,7 +5,10 @@ export default {
   title: "pages/CliAuthPageView",
   component: CliAuthPageView,
   argTypes: {
-    sessionToken: { control: "text", defaultValue: "some-session-token" },
+    sessionToken: { control: "text" },
+  },
+  args: {
+    sessionToken: "some-session-token",
   },
 }
 

diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
@@ -135,6 +135,7 @@ RichParameters.args = {
     MockTemplateVersionParameter3,
     {
       name: "Region",
+      required: false,
       description: "",
       description_plaintext: "",
       type: "string",

diff --git a/site/src/pages/WorkspacesPage/WorkspacesPageView.stories.tsx b/site/src/pages/WorkspacesPage/WorkspacesPageView.stories.tsx
@@ -58,10 +58,8 @@ const allWorkspaces = [
 export default {
   title: "pages/WorkspacesPageView",
   component: WorkspacesPageView,
-  argTypes: {
-    limit: {
-      defaultValue: DEFAULT_RECORDS_PER_PAGE,
-    },
+  args: {
+    limit: DEFAULT_RECORDS_PER_PAGE,
   },
 } as ComponentMeta<typeof WorkspacesPageView>
 

diff --git a/site/vite.config.ts b/site/vite.config.ts
@@ -25,6 +25,7 @@ export default defineConfig({
   define: {
     "process.env": {
       NODE_ENV: process.env.NODE_ENV,
+      STORYBOOK: process.env.STORYBOOK,
       INSPECT_XSTATE: process.env.INSPECT_XSTATE,
     },
   },
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,6 +24,7 @@ Example.args = { @@
         },
         MockTemplateVersion,
       ],
+      onPromoteClick: undefined,
     }
     export const CanPromote = Template.bind({})
@@ Expand Down @@