Skip to content

ci: skip ts or go tests based on changed files #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 9, 2023
Merged

ci: skip ts or go tests based on changed files #7134

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3e45a82
chore: skip ts or go tests based on files changed
deansheather Apr 14, 2023
42af709
comments
deansheather Apr 17, 2023
67f6d43
chore: add 'required' job
deansheather Apr 24, 2023
e23cb5e
fixup! chore: add 'required' job
deansheather Apr 24, 2023
352440d
fake go modification
deansheather Apr 24, 2023
8f791fc
Merge branch 'main' into dean/skip-tests-fe-be
matifali Jun 9, 2023
8f0903d
merge main into dean/skip-tests-fe-be
matifali Jun 9, 2023
e02a408
fix typo
matifali Jun 9, 2023
8f9828c
remove x_test.go
matifali Jun 9, 2023
cfcc52c
remove duplicate setup-node action
matifali Jun 9, 2023
7ff9c2c
condition test-go-race too
matifali Jun 9, 2023
0695cb9
skip ete on docs changes
matifali Jun 9, 2023
77162d9
allows tests to run if changes are made .github directory
matifali Jun 9, 2023
62fbfd1
Merge branch 'main' into dean/skip-tests-fe-be
matifali Jun 9, 2023
cdb351f
Merge branch 'main' into dean/skip-tests-fe-be
matifali Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allows tests to run if changes are made .github directory
  • Loading branch information
@matifali
matifali committed Jun 9, 2023
commit 77162d91e6a7b503b3b6363ca1a9648f5b94d6b4
19 changes: 11 additions & 8 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
go: ${{ steps.filter.outputs.go }}
ts: ${{ steps.filter.outputs.ts }}
k8s: ${{ steps.filter.outputs.k8s }}
ci: ${{ steps.filter.outputs.ci }}
steps:
- uses: actions/checkout@v3
# For pull requests it's not necessary to checkout the code
Expand Down Expand Up @@ -85,6 +86,8 @@ jobs:
- "scripts/Dockerfile"
- "scripts/Dockerfile.base"
- "scripts/helm.sh"
ci:
- ".github/**"
- id: debug
run: |
echo "${{ toJSON(steps.filter )}}"
Expand Down Expand Up @@ -145,7 +148,7 @@ jobs:
timeout-minutes: 8
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.docs-only == 'false' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.docs-only == 'false' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -212,7 +215,7 @@ jobs:
test-go:
runs-on: ${{ matrix.os == 'ubuntu-latest' && github.repository_owner == 'coder' && 'buildjet-4vcpu-ubuntu-2204' || matrix.os == 'windows-2019' && github.repository_owner == 'coder' && 'windows-latest-8-cores'|| matrix.os }}
needs: changes
if: needs.changes.outputs.go == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
timeout-minutes: 20
strategy:
matrix:
Expand Down Expand Up @@ -281,7 +284,7 @@ jobs:
test-go-pg:
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.go == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
# goroutines. Setting this to the timeout +5m should work quite well
Expand Down Expand Up @@ -336,7 +339,7 @@ jobs:
test-go-race:
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.go == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
timeout-minutes: 25
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -449,7 +452,7 @@ jobs:
test-js:
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.ts == 'true' || github.ref == 'refs/heads/main'
if: needs.changes.outputs.ts == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
timeout-minutes: 20
steps:
- uses: actions/checkout@v3
Expand All @@ -472,9 +475,9 @@ jobs:
flags: unittest-js

test-e2e:
needs: changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ts == 'true' || github.ref == 'refs/heads/main'
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ts == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
timeout-minutes: 20
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -512,7 +515,7 @@ jobs:
# REMARK: this is only used to build storybook and deploy it to Chromatic.
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.ts == 'true'
if: needs.changes.outputs.ts == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
steps:
- uses: actions/checkout@v3
with:
Expand Down