Skip to content

feat(helm): add labels for coder pod #7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat(helm): add labels for coder pod #7139

merged 4 commits into from
Apr 14, 2023

Conversation

ericpaulsen
Copy link
Member

adds support for labeling the coder pod via the existing coder.labels. @deansheather let me know if you think it's best to have a separate value from the deployment label.

@ericpaulsen ericpaulsen self-assigned this Apr 14, 2023
@ericpaulsen
Copy link
Member Author

i'm getting the following error when running make update-golden-files:

Error: YAML parse error on coder/templates/coder.yaml: error converting YAML to JSON: yaml: line 28: did not find expected key

@deansheather let me know how to resolve. i'm not sure why my syntax is incorrect.

@ericpaulsen ericpaulsen enabled auto-merge (squash) April 14, 2023 17:18
@bpmct bpmct disabled auto-merge April 14, 2023 17:20
@bpmct bpmct enabled auto-merge (squash) April 14, 2023 17:25
@bpmct bpmct merged commit c37f22b into main Apr 14, 2023
@bpmct bpmct deleted the pod-labels branch April 14, 2023 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants