Skip to content

chore: Update pion/udp and improve parallel/non-parallel tests #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2023
Merged

chore: Update pion/udp and improve parallel/non-parallel tests #7164

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec0cc6b
test(all): Improve and fix subtests with parallell/nonparallel parents
mafredri Apr 17, 2023
c4a068f
Use one-level of subtests in port test
mafredri Apr 17, 2023
67caa6a
Update pion/udp
mafredri Apr 17, 2023
2f1e8ec
Fix nolint
mafredri Apr 17, 2023
28bdc50
Fix nolint
mafredri Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix nolint
  • Loading branch information
@mafredri
mafredri committed Apr 17, 2023
commit 2f1e8ec08452ead6009a6cc9342d4b53f1cf902f
4 changes: 2 additions & 2 deletions cli/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,7 @@ func TestServer(t *testing.T) {
})
}

//nolint:paralleltest // This test spawns or connects to an existing PostgreSQL instance.
//nolint:tparallel,paralleltest // This test spawns or connects to an existing PostgreSQL instance.
func TestServer_Production(t *testing.T) {
if runtime.GOOS != "linux" || testing.Short() {
// Skip on non-Linux because it spawns a PostgreSQL instance.
Expand Down Expand Up @@ -1461,7 +1461,7 @@ func TestServer_Production(t *testing.T) {
require.NoError(t, err)
}

//nolint:paralleltest // This test cannot be run in parallel due to signal handling.
//nolint:tparallel,paralleltest // This test cannot be run in parallel due to signal handling.
func TestServer_Shutdown(t *testing.T) {
if runtime.GOOS == "windows" {
// Sending interrupt signal isn't supported on Windows!
Expand Down