Skip to content

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Apr 17, 2023

Close #5573

@BrunoQuaresma BrunoQuaresma requested review from bpmct and a team April 17, 2023 16:47
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 17, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team April 17, 2023 16:47
@@ -1621,7 +1617,7 @@ const (
// users to opt-in to via --experimental='*'.
// Experiments that are not ready for consumption by all users should
// not be included here and will be essentially hidden.
var ExperimentsAll = Experiments{ExperimentTemplateEditor}
var ExperimentsAll = Experiments{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above comment is confusing to me - "should not be included here"? I assume any experiment included in this struct will be hidden.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kinda is 🤔

@BrunoQuaresma BrunoQuaresma merged commit 76b5dee into main Apr 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-template-editor-from-experimental branch April 17, 2023 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template web editor
2 participants