Skip to content

test(agent/reaper): Fix restructure issue #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023
Merged

test(agent/reaper): Fix restructure issue #7168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(agent/reaper): Fix restructure issue 
In #7164 we accidentally removed the "in CI" check, this fixes it.
  • Loading branch information
@mafredri
mafredri committed Apr 17, 2023
commit 8a8d3b221745e804b7d9e4583e3c641de8b73826
13 changes: 5 additions & 8 deletions agent/reaper/reaper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ import (
"github.com/coder/coder/testutil"
)

//nolint:paralleltest // Non-parallel subtest.
// TestReap checks that's the reaper is successfully reaping
// exited processes and passing the PIDs through the shared
// channel.
//
//nolint:paralleltest
func TestReap(t *testing.T) {
// Don't run the reaper test in CI. It does weird
// things like forkexecing which may have unintended
Expand All @@ -27,13 +31,6 @@ func TestReap(t *testing.T) {
t.Skip("Detected CI, skipping reaper tests")
}

// OK checks that's the reaper is successfully reaping
// exited processes and passing the PIDs through the shared
// channel.
}

//nolint:paralleltest // Signal handling.
func TestReap_OK(t *testing.T) {
pids := make(reap.PidCh, 1)
err := reaper.ForkReap(
reaper.WithPIDCallback(pids),
Expand Down