Skip to content

fix(site): Close WS and SE connections when they are not used #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

About the fix:

  • Change the watch services to return a function closing the connection
  • Refactor the promises to regular functions where they can do actions when receiving a message, or error or when it is done
  • Transition the watching state to something else using a callback event

⚠️ This touches some important parts of the UI so I would love some extra QA:

  • Workspace page - Check if the statuses are being updated automatically and the startup logs as well
  • Template version logs - Check if the logs are being displayed correctly
  • Template version editor - Check if the logs are showing correctly

Fix #6782

@BrunoQuaresma BrunoQuaresma requested review from kylecarbs, Kira-Pilot and a team April 18, 2023 14:59
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 18, 2023
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like its working to me!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 20, 2023 15:52
@BrunoQuaresma BrunoQuaresma merged commit e90a076 into main Apr 20, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-web-socket-connections branch April 20, 2023 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket connections are not closing when users navigating away from the page
2 participants