chore: Enforce workspace proxy unique name case insensitive #7202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Apr 19, 2023
| DROP INDEX IF EXISTS workspace_proxies_lower_name_idx; | ||
|
|
||
| -- Enforces no active proxies have the same name. | ||
| CREATE UNIQUE INDEX ON workspace_proxies (name) WHERE deleted = FALSE; |
There was a problem hiding this comment.
shouldn't it be CREATE UNIQUE INDEX workspace_proxies_name_idx ON workspace_proxies USING btree (name) WHERE deleted = FALSE;?
There was a problem hiding this comment.
Nop, I copied the previous migration that added the index:
coder/coderd/database/migrations/000114_workspace_proxy.up.sql
Lines 20 to 21 in 9e218f7
Forgot to use a btree there, so kept it as it was for the Down.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the PR #7176 merged to write the unit tests 😢. It has the http endpoints to test.