Skip to content

fix(cli/clitest): race between Start/StartWithWaiter cleanup order #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix(cli/clitest): race between Start/StartWithWaiter cleanup order #7232

merged 2 commits into from
Apr 20, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 20, 2023

Noticed this was the true culprit for #7231

@coadler coadler requested review from mafredri and ammario April 20, 2023 19:48
@ammario ammario removed their request for review April 20, 2023 20:30
@coadler coadler enabled auto-merge (squash) April 20, 2023 23:35
@coadler coadler merged commit ac3c530 into main Apr 20, 2023
@coadler coadler deleted the colin/clitest-cleanup-race branch April 20, 2023 23:41
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @mafredri