Skip to content

fix: coder_parameter fallbacks to default #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: coder_parameter fallbacks to default #7240

merged 1 commit into from
Apr 24, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 21, 2023 •
edited
Loading

Fixes: #7238
Fixes: #7213

While I was investigating mentioned issues, I found some regression related to edge cases with default and legacy that may give a bad user experience. I have covered the backend part with extra unit tests.

Changes:

  • backend: use default parameter value if it can't be found in the previous build request or among legacy parameters
  • frontend: adjust legacy migration logic, just defer it to the backend

@mtojek mtojek requested a review from BrunoQuaresma April 21, 2023 11:05
@mtojek mtojek marked this pull request as ready for review April 21, 2023 11:05
@mtojek mtojek mentioned this pull request Apr 21, 2023
Closed
BrunoQuaresma
BrunoQuaresma approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit c000f2e into coder:main Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional coder_parameters aren't truly optional? Adding or updating parameters in a template causes existing workspaces to re-enter all parameters
2 participants
@mtojek @BrunoQuaresma