chore: fix flake in apptest reconnecting-pty test #7281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Apr 25, 2023
| bufRead := bufio.NewReader(conn) | ||
|
|
||
| // Brief pause to reduce the likelihood that we send keystrokes while | ||
| // the shell is simultaneously sending a prompt. | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
I guess we can't expect prompt first? If we could set env PS1=> then we'd have something to look for.
There was a problem hiding this comment.
PS1 doesn't seem to be accepted through env in bash, only as a variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the tests identical because the other ones work. I had to change the codersdk methods a bit to accomplish this.
https://github.com/coder/coder/actions/runs/4786259967/jobs/8510272554