feat: UI/UX for regions #7283
Merged
feat: UI/UX for regions #7283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So an admin can set an icon for each workspace proxy? |
Yes. Figured that kinda our pattern for other resources and icons are fun |
Fixed, good catch. We added a route that was gated by the feature flag. We changed the endpoint to always be accessible, and forgot to update the code to reflect that. I fixed this. |
|
Throughout this PR, seems like we're using 'proxy' and 'region' interchangeably. Can we pick one and be consistent? |
Kira-Pilot
reviewed
Apr 27, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
Delete extra hook Renames regions -> proxies
Kira-Pilot
reviewed
Apr 28, 2023
Kira-Pilot
reviewed
Apr 28, 2023
site/src/pages/UserSettingsPage/WorkspaceProxyPage/WorkspaceProxyRow.tsx
Outdated
Show resolved
Hide resolved
Kira-Pilot
reviewed
Apr 28, 2023
site/src/pages/UserSettingsPage/WorkspaceProxyPage/WorkspaceProxyRow.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
When you select a workspace proxy, that proxy will be used for links on the workspace dashboard. App links change based on the selected proxy. The terminal changes what websocket url it uses based on the proxy.
Removed getting
application hostfrom other parts in the codebase. Using a context instead.Missing funcationality
Right now the terminal does not work with a workspace proxy because of the CSP policy. The error is:
This is known and not fixed in this PR. If you remove that CSP policy, it does work. We setup CORs to work, but the CSP requires more refactoring. This will happen in another PR. See #7308
Testing
Must have
moonsexperiment enabled!Not done
If the selected proxy becomes unhealthy, the links will still direct to it.
Styling TBD
All of this is feature flagged. We can make things prettier before we release. Just getting a functional UI in.
Without experiment on
If
moonsexperiment is not enabled, no UI changes happen.