Skip to content

feat(agent): add http debug routes for magicsock #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2023
Merged

feat(agent): add http debug routes for magicsock #7287

merged 3 commits into from
Apr 26, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 25, 2023 •
edited
Loading

Exposes Tailscale's magicsock debug, which can be helpful when debugging connections.

image

@coadler coadler self-assigned this Apr 25, 2023
@coadler coadler force-pushed the colin/agent-http-debug2 branch 2 times, most recently from 839ae15 to 3138432 Compare April 25, 2023 23:18
@coadler coadler force-pushed the colin/agent-http-debug2 branch from 9187327 to a3d2a9e Compare April 25, 2023 23:41
@coadler coadler requested review from mafredri and mtojek April 25, 2023 23:46
mtojek
mtojek approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

mafredri
mafredri approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be careful about using up ports in user workspaces, but don't really have a suggestion for an improvement here. Maybe this debug endpoint could be enabled on-demand or something in future.

@coadler
Copy link
Contributor Author

coadler commented Apr 26, 2023

I think we should be careful about using up ports in user workspaces, but don't really have a suggestion for an improvement here. Maybe this debug endpoint could be enabled on-demand or something in future.

Yeah, I was thinking about that while writing this. I think users probably wouldn't be too stoked we're automatically taking up some commonly used ports. Another thing we could do is use some of our reserved ports in Wireguard, but then a user couldn't port-forward to them.

@coadler coadler merged commit 3eb7f06 into main Apr 26, 2023
@coadler coadler deleted the colin/agent-http-debug2 branch April 26, 2023 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @mafredri @mtojek