Skip to content

fix(site): Fix secondary buttons with popovers #7296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix(site): Fix secondary buttons with popovers #7296

merged 1 commit into from
Apr 26, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Secondary buttons where not forwarding the ref so the popover was missing the right positioning.

@BrunoQuaresma BrunoQuaresma requested a review from a team April 26, 2023 12:50
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 26, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team April 26, 2023 12:50
rodrimaia
rodrimaia approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! =D

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 26, 2023 15:29
@BrunoQuaresma BrunoQuaresma merged commit 0e46903 into main Apr 26, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-ssh-popover branch April 26, 2023 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rodrimaia rodrimaia rodrimaia approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @rodrimaia