Skip to content

feat: Add aws-windows and aws-linux examples #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 31, 2022
Merged

feat: Add aws-windows and aws-linux examples #730

merged 11 commits into from
Mar 31, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Mar 30, 2022 •
edited
Loading

this adds example projects for Windows and Linux VMs on AWS

@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #730 (acedca5) into main (3abb87d) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   64.28%   64.08%   -0.20%     
==========================================
  Files         198      199       +1     
  Lines       11622    11826     +204     
  Branches       85       87       +2     
==========================================
+ Hits         7471     7579     +108     
- Misses       3356     3426      +70     
- Partials      795      821      +26
Flag Coverage Δ
unittest-go- 63.15% <ø> (-0.15%) ⬇️
unittest-go-macos-latest 58.97% <ø> (-0.28%) ⬇️
unittest-go-ubuntu-latest 61.89% <ø> (-0.38%) ⬇️
unittest-go-windows-2022 58.10% <ø> (-0.19%) ⬇️
unittest-js 62.63% <ø> (-0.70%) ⬇️
Impacted Files Coverage Δ
site/src/components/Form/FormTextField.tsx 59.37% <0.00%> (-31.25%) ⬇️
site/src/components/Form/PasswordField.tsx 80.00% <0.00%> (-6.67%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
cli/ssh.go 38.88% <0.00%> (-4.45%) ⬇️
agent/conn.go 65.38% <0.00%> (-3.59%) ⬇️
agent/agent.go 67.30% <0.00%> (-1.09%) ⬇️
coderd/workspaceresources.go 60.97% <0.00%> (-0.57%) ⬇️
cli/start.go 65.74% <0.00%> (-0.42%) ⬇️
provisionerd/provisionerd.go 80.02% <0.00%> (-0.30%) ⬇️
site/src/components/Form/index.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb87d...acedca5. Read the comment docs.

@bpmct bpmct requested a review from kylecarbs March 30, 2022 14:12
kylecarbs
kylecarbs requested changes Mar 30, 2022
View reviewed changes
coadler
coadler reviewed Mar 30, 2022
View reviewed changes
@bpmct bpmct requested a review from kylecarbs March 30, 2022 17:58
kylecarbs
kylecarbs approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example additions! Just a few minor nits.

@kylecarbs kylecarbs changed the title feat(examples): add README, aws-windows, aws-linux feat: Add aws-windows and aws-linux examples Mar 31, 2022
@kylecarbs kylecarbs merged commit e759b4a into main Mar 31, 2022
@kylecarbs kylecarbs deleted the bpmct/add-samples branch March 31, 2022 15:41
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
@DanyRay420 DanyRay420 mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn left review comments

@coadler coadler coadler left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
5 participants
@bpmct @johnstcn @coadler @kylecarbs @misskniss