fix(UI): workspace restart button stops build before starting a new one #7301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor primary buttons * refactor(site): Always show the main actions * Remove tests that are testes on Storybook * Fix tests * Fix keys * added restart btn --------- Co-authored-by: BrunoQuaresma <bruno_nonato_quaresma@hotmail.com>
Kira-Pilot
commented
Apr 26, 2023
Kira-Pilot
commented
Apr 26, 2023
| } | ||
| }, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Originally, I wanted to use an implementation closer to the following, which react query's docs suggest is possible:
const requestStopWorkspace = useMutation({ mutationFn: stopWorkspace })
const requestStartWorkspace = useMutation({ mutationFn: startWorkspace })
const restartWorkspace = async () => {
try {
await requestStopWorkspace.mutateAsync(workspace.id)
await waitForStop(requestStopWorkspace.data)
await requestStartWorkspace.mutateAsync({
workspaceId,
templateVersionId,
})
} catch (error) {
...
}
}
but mutateAsync does not seem to be working and the queries are not treated asynchronously. @BrunoQuaresma is this something you've run into before?
There was a problem hiding this comment.
I put a comment above, I think you don't need to have each API call into a "query". You can have a single function to restart the workspace and wrap this function into a query.
There was a problem hiding this comment.
Hmmm that's a good idea. Let me try it!
There was a problem hiding this comment.
@BrunoQuaresma Woo that's a lot better! Thanks!
|
Thank you for fixing this so quickly :) |
BrunoQuaresma
approved these changes
Apr 27, 2023
bpmct
reviewed
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6241 and replaces the reverted #7268.
I've added a test to ensure the restart button hook is called appropriately but React Query makes it difficult to test side effects so I'm effectively mocking the
stopWorkspaceapi call and not thestartWorkspaceapi call. I will take a second look at this during a quieter day, but for the time being, smoke testing would be appreciated!