Skip to content

fix: vite fatals on receiving HTTP4xx #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2023
Merged

fix: vite fatals on receiving HTTP4xx #7306

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dee966f
fix: vite fatals on receiving HTTP4xx
mtojek Apr 27, 2023
ffe08a6
tune Vite
mtojek Apr 27, 2023
b8f1a9d
fmt
mtojek Apr 27, 2023
282fc2c
rewrite
mtojek Apr 27, 2023
6de9a17
fmt
mtojek Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rewrite
  • Loading branch information
@mtojek
mtojek committed Apr 27, 2023
commit 282fc2cc0f9b640a4172569b0ddc6c585269064f
5 changes: 1 addition & 4 deletions coderd/workspaceagents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,10 +447,7 @@ func (api *API) workspaceAgentStartupLogs(rw http.ResponseWriter, r *http.Reques
api.WebsocketWaitGroup.Add(1)
api.WebsocketWaitMutex.Unlock()
defer api.WebsocketWaitGroup.Done()
conn, err := websocket.Accept(rw, r, &websocket.AcceptOptions{
// Vite in development mode can't cross-access this port.
OriginPatterns: []string{"localhost:8080"},
})
conn, err := websocket.Accept(rw, r, nil)
if err != nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Message: "Failed to accept websocket.",
Expand Down
4 changes: 4 additions & 0 deletions site/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ export default defineConfig({
// As /startup-logs endpoint can return HTTP 4xx status, we need to embrace
// Vite with a custom error handler to prevent from quitting.
proxy.on("proxyReqWs", (proxyReq, req, socket) => {
if (process.env.NODE_ENV === "development") {
proxyReq.setHeader('origin', process.env.CODER_HOST || "http://localhost:3000");
}

socket.on("error", (error) => {
console.error(error)
})
Expand Down