feat(cli): add trafficgen command for load testing #7307
Conversation
5163ed5 to
7fe2e74
Compare
| Data string `json:"data,omitempty"` | ||
| Height uint16 `json:"height,omitempty"` | ||
| Width uint16 `json:"width,omitempty"` |
There was a problem hiding this comment.
review: Added omitempty here to reduce the size of the payload.
| r.vscodeSSH(), | ||
| r.workspaceAgent(), |
There was a problem hiding this comment.
review: I'm assuming all of this wants to be sorted alphabetically.
| var ( | ||
| pageNumber = 0 | ||
| limit = 100 | ||
| workspaces []codersdk.Workspace | ||
| ) | ||
| for { | ||
| page, err := client.Workspaces(ctx, codersdk.WorkspaceFilter{ | ||
| Name: "scaletest-", | ||
| Offset: pageNumber * limit, | ||
| Limit: limit, | ||
| }) | ||
| if err != nil { | ||
| return xerrors.Errorf("fetch scaletest workspaces page %d: %w", pageNumber, err) | ||
| } | ||
|
|
||
| pageNumber++ | ||
| if len(page.Workspaces) == 0 { | ||
| break | ||
| } | ||
|
|
||
| pageWorkspaces := make([]codersdk.Workspace, 0, len(page.Workspaces)) | ||
| for _, w := range page.Workspaces { | ||
| if isScaleTestWorkspace(w) { | ||
| pageWorkspaces = append(pageWorkspaces, w) | ||
| } | ||
| } | ||
| workspaces = append(workspaces, pageWorkspaces...) |
There was a problem hiding this comment.
review: extracted to function
| pageNumber = 0 | ||
| limit = 100 | ||
| var users []codersdk.User | ||
| for { | ||
| page, err := client.Users(ctx, codersdk.UsersRequest{ | ||
| Search: "scaletest-", | ||
| Pagination: codersdk.Pagination{ | ||
| Offset: pageNumber * limit, | ||
| Limit: limit, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| return xerrors.Errorf("fetch scaletest users page %d: %w", pageNumber, err) | ||
| } | ||
|
|
||
| pageNumber++ | ||
| if len(page.Users) == 0 { | ||
| break | ||
| } | ||
|
|
||
| pageUsers := make([]codersdk.User, 0, len(page.Users)) | ||
| for _, u := range page.Users { | ||
| if isScaleTestUser(u) { | ||
| pageUsers = append(pageUsers, u) | ||
| } | ||
| } | ||
| users = append(users, pageUsers...) |
There was a problem hiding this comment.
review: extracted to function
89e9f95 to
4f165be
Compare
| codersdk.BypassRatelimitHeader: {"true"}, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Suggestion: Since header transport isn't implementing close idler, client.HTTPClient.CloseIdleConnections() won't work. This might be a good addition to avoid leaks in tests:
(Or alternatively, implementing type closeIdler interface { CloseIdleConnections() } on headerTransport and doing the client variant.)
defer http.DefaultTransport.(*http.Transport).CloseIdleConnections()
cli/root.go
Outdated
| r.gitssh(), | ||
| r.scaletest(), |
There was a problem hiding this comment.
scaletest is no longer hidden, even if your trafficgen subcommand is
There was a problem hiding this comment.
Sorry, I meant that coder scaletest is not hidden, so this shouldn't be in the // Hidden section of the list.
scaletest/workspacetraffic/config.go
Outdated
| // Duration is the total duration for which to send traffic to the agent. | ||
| Duration time.Duration `json:"duration"` | ||
|
|
||
| // TicksInterval specifies how many times per second we send traffic. |
There was a problem hiding this comment.
this comment is outdated; this is now the interval/period, not the frequency.
This PR adds a hidden
scaletest trafficgencommand for load testing.ReconnectingPTYconnection to each scaletest workspace, and concurrently writes and reads random data to/from the PTY.#${RANDOM_ALPHANUMERIC_STRING}, which essentially drops garbage comments in the remote shell, and should not result in any commands being executed.Future work: