Skip to content

feat: add AWS MacOS examples #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: add AWS MacOS examples #731

wants to merge 2 commits into from

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Mar 30, 2022

AWS allows users to reserve a "dedicated mac mini instance" and then provision a single "EC2 instance" on it. This project automates the process.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #731 (9ef24fd) into main (3abb87d) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   64.28%   64.39%   +0.11%     
==========================================
  Files         198      198              
  Lines       11622    11622              
  Branches       85       85              
==========================================
+ Hits         7471     7484      +13     
+ Misses       3356     3344      -12     
+ Partials      795      794       -1     
Flag Coverage Δ
unittest-go- 63.58% <ø> (+0.27%) ⬆️
unittest-go-macos-latest 59.05% <ø> (-0.19%) ⬇️
unittest-go-ubuntu-latest 62.02% <ø> (-0.24%) ⬇️
unittest-go-windows-2022 58.27% <ø> (-0.02%) ⬇️
unittest-js 63.32% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/workspaceresources.go 59.72% <0.00%> (-1.81%) ⬇️
provisionerd/provisionerd.go 80.17% <0.00%> (-0.15%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
peer/conn.go 79.69% <0.00%> (+0.25%) ⬆️
coderd/provisionerdaemons.go 62.56% <0.00%> (+2.52%) ⬆️
coderd/parameter/compute.go 78.51% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb87d...9ef24fd. Read the comment docs.

@bpmct
Copy link
Member Author

bpmct commented Mar 30, 2022

I need to find a way to work with the init on OSX that AWS uses. aws/ec2-macos-init#6

@greyscaled greyscaled changed the title feat(examples): add AWS MacOS feat: add AWS MacOS examples Apr 7, 2022
@misskniss misskniss modified the milestones: V2 Beta, Community MVP May 15, 2022
@misskniss misskniss removed the V2 BETA label May 16, 2022
@kylecarbs
Copy link
Member

@bpmct should we merge or close this?

@bpmct
Copy link
Member Author

bpmct commented Jul 21, 2022

let's close for now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants