Skip to content

refactor(site): Refactor error state #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2023
Merged

refactor(site): Refactor error state #7313

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f5af05
Refactor error screen
BrunoQuaresma Apr 27, 2023
b183d4e
Send info to open issue
BrunoQuaresma Apr 27, 2023
32a4d9e
Fix stories
BrunoQuaresma Apr 27, 2023
2f505cb
Add stack trace
BrunoQuaresma Apr 27, 2023
7c81c4c
Enable source maps
BrunoQuaresma Apr 27, 2023
d0cbeee
Remove const
BrunoQuaresma Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions site/src/components/Margins/Margins.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { makeStyles } from "@material-ui/core/styles"
import { FC } from "react"
import { combineClasses } from "utils/combineClasses"
import {
containerWidth,
containerWidthMedium,
Expand All @@ -24,14 +25,15 @@ const useStyles = makeStyles(() => ({
},
}))

interface MarginsProps {
size?: Size
}

export const Margins: FC<React.PropsWithChildren<MarginsProps>> = ({
children,
export const Margins: FC<JSX.IntrinsicElements["div"] & { size?: Size }> = ({
size = "regular",
...divProps
}) => {
const styles = useStyles({ maxWidth: widthBySize[size] })
return <div className={styles.margins}>{children}</div>
return (
<div
{...divProps}
className={combineClasses([styles.margins, divProps.className])}
/>
)
}
10 changes: 4 additions & 6 deletions site/src/components/RuntimeErrorState/RuntimeErrorState.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
import { ComponentMeta, Story } from "@storybook/react"
import { Story } from "@storybook/react"
import { RuntimeErrorState, RuntimeErrorStateProps } from "./RuntimeErrorState"

const error = new Error("An error occurred")

export default {
title: "components/RuntimeErrorState",
component: RuntimeErrorState,
argTypes: {
error: {
defaultValue: error,
},
args: {
error,
},
} as ComponentMeta<typeof RuntimeErrorState>
}

const Template: Story<RuntimeErrorStateProps> = (args) => (
<RuntimeErrorState {...args} />
Expand Down
54 changes: 0 additions & 54 deletions site/src/components/RuntimeErrorState/RuntimeErrorState.test.tsx
View file
Open in desktop

This file was deleted.

Loading