Skip to content

chore: minor tweaks to license ui #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2023
Merged

chore: minor tweaks to license ui #7314

merged 3 commits into from
Apr 28, 2023

Conversation

rodrimaia
Copy link
Contributor

minor tweaks:

  • Change 40 / Unlimited users to 40 users / Unlimited
  • Change Add new License to Add new license
  • Change February 3, 2024\nValid until to Valid until\nFebruary 3, 2024

new screenshot:
image

@rodrimaia rodrimaia requested a review from a team April 27, 2023 20:13
@rodrimaia rodrimaia self-assigned this Apr 27, 2023
@rodrimaia rodrimaia requested review from BrunoQuaresma and removed request for a team April 27, 2023 20:13
@matifali
Copy link
Member

matifali commented Apr 27, 2023 •
edited
Loading

What do you think about changing to

Users: 2 / 25

Or

Users
2 / 25

BrunoQuaresma
BrunoQuaresma approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with them just notice one thing, when there is a single license, it is showing "users" in the plural. Also, what do you think about @matifali suggestion? Up to you.

@rodrimaia
Copy link
Contributor Author

Thank you for the suggestions Bruno and @matifali . updated version:
image

@matifali
Copy link
Member

One last thing, do we have a double-check when the user clicks on remove? We should not allow removing license accidentally.

@bpmct
Copy link
Member

bpmct commented Apr 28, 2023 •
edited
Loading

One last thing, do we have a double-check when the user clicks on remove? We should not allow removing license accidentally.

There is a confirmation dialog :)

@rodrimaia
Copy link
Contributor Author

One last thing, do we have a double-check when the user clicks on remove? We should not allow removing license accidentally.

Yes, we do! :). check the storybook: https://624de63c6aacee003aa84340-fcdxyiamxe.chromatic.com/?path=/story/pages-licensessettingspage--default

@rodrimaia rodrimaia enabled auto-merge (squash) April 28, 2023 13:56
@rodrimaia rodrimaia merged commit d3a9d7c into main Apr 28, 2023
@rodrimaia rodrimaia deleted the license_ui_minor branch April 28, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct bpmct approved these changes

Assignees

@rodrimaia rodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrimaia @matifali @bpmct @BrunoQuaresma