fix(coderd): don't hang on first gitauth clone #7331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `coder git ssh` command would hang on the API, which was endlessly polling the database for oauth tokens that expire in the future. Some oAuth implementations (including GitHub by default) will not give back a token expiry date, and the absence of a token expiry date became the zero date in the database. Follow-up calls to `git clone` would succeed because the non-listen path doesn't check expiry, perhaps by mistake. In addition to fixing the zero date issue, this PR removes the PubSub which added too much complexity when the polling interval is 1 second.
kylecarbs
approved these changes
May 1, 2023
kylecarbs
approved these changes
May 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
coder git sshcommand would hang on the API, which was endlessly polling the database for oauth tokens that expire in the future.Some oAuth implementations (including GitHub by default) will not give back a token expiry date, and the absence of a token expiry date became the zero date in the database.
Follow-up calls to
git clonewould succeed because the non-polling path doesn't check expiry, perhaps by mistake.In addition to fixing the zero date issue, this PR removes the PubSub which added too much complexity when the polling interval is 1 second.