Skip to content

feat: unified tracing between coderd<->provisionerd #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2023
Merged

feat: unified tracing between coderd<->provisionerd #7370

merged 3 commits into from
May 3, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 2, 2023 •
edited
Loading

@coadler coadler self-assigned this May 2, 2023
@coadler coadler changed the title feat: allow unified tracing between coderd<->provisionerd feat: unified tracing between coderd<->provisionerd May 2, 2023
@coadler coadler force-pushed the colin/drpc-trace branch from 7a701de to dcf3a56 Compare May 3, 2023 00:41
@coadler coadler marked this pull request as ready for review May 3, 2023 00:57
@coadler coadler force-pushed the colin/drpc-trace branch 2 times, most recently from ba06fe5 to 611aec4 Compare May 3, 2023 01:16
@coadler coadler force-pushed the colin/drpc-trace branch from b6cfb80 to 613fd30 Compare May 3, 2023 01:27
@coadler coadler requested a review from deansheather May 3, 2023 01:44
kylecarbs
kylecarbs reviewed May 3, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on making the column explicitly for tracing instead of metadata right now? It could be a bit misleading to a reader atm.

@coadler
Copy link
Contributor Author

coadler commented May 3, 2023

Thoughts on making the column explicitly for tracing instead of metadata right now? It could be a bit misleading to a reader atm.

Yeah I think that's pretty reasonable. I noticed later on we also have other unrelated things called metadata which could be confusing.

deansheather
deansheather approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I agree with Kyle that you should change the field name in the DB.

It'd also be good if the external provisionerd server started tracing too.

@coadler coadler enabled auto-merge (squash) May 3, 2023 23:00
@coadler coadler merged commit 8bd9f9c into main May 3, 2023
@coadler coadler deleted the colin/drpc-trace branch May 3, 2023 23:02
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@deansheather deansheather deansheather approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @deansheather