docs: make use of display_name and name in Open with Coder
#7372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removed the spaces from `name` and makes it equal to the resource name as we now have a sperate field `display_name` #6919 The docs references https://github.com/bpmct/coder-templates/tree/main/kubernetes-open-in-coder example which does not yet makes use of `display name` and needs updating.
bpmct
approved these changes
May 2, 2023
|
Thanks a ton for doing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Open in Coder link easier to read and type, as
namedoes not have any spaces now.This PR removed the spaces from
nameand makes it equal to the resource name as we now have a separate fielddisplay_name#6919The docs reference https://github.com/bpmct/coder-templates/tree/main/kubernetes-open-in-coder example which does not yet makes use of
display nameand needs updating.@bpmct, please update the example if required.