fix: pty.Start respects context on Windows too #7373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
mafredri
approved these changes
May 2, 2023
| @@ -449,7 +449,7 @@ func (s *Server) CreateCommand(ctx context.Context, script string, env []string) | |||
| } | |||
| } | |||
|
|
|||
| cmd := exec.CommandContext(ctx, shell, args...) | |||
| cmd := pty.CommandContext(ctx, shell, args...) | |||
There was a problem hiding this comment.
Suggestion: Perhaps we should discourage the use of non-context commands and rename this to pty.Command? Main reason stdlib has two is that it's a later addition.
There was a problem hiding this comment.
Yeah, but then it wouldn't be a drop-in replacement.
I like keeping the same API as the standard library so people will find it familiar, even though it's tempting to "improve" the API.
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
respect for the
cmd.Contextin theptylibrary was inconsistent between platforms because in Windows we don't actually useexecto start the child process.This corrects this platform inconsistency and removes the hacks we added to work around it.