Skip to content

refactor(site): Show immutable parameters in the settings #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2023
Merged

refactor(site): Show immutable parameters in the settings #7383

merged 5 commits into from
May 3, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Added “Parameters” to the Workspace Settings page
  • Display, as disabled, the immutable parameters as well so the user knows what values were used

image

Close #7290

@BrunoQuaresma BrunoQuaresma requested a review from a team May 2, 2023 17:48
@BrunoQuaresma BrunoQuaresma self-assigned this May 2, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team May 2, 2023 17:48
rodrimaia
rodrimaia approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@BrunoQuaresma BrunoQuaresma merged commit 2ea438c into main May 3, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/show-immutable-parameters branch May 3, 2023 17:40
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rodrimaia rodrimaia rodrimaia approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how can I see my workspace's immutable parameters?
3 participants
@BrunoQuaresma @rodrimaia @kylecarbs