Skip to content

fix(site): Fix template icon field validation #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 4, 2023
Merged

fix(site): Fix template icon field validation #7394

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
542a563
fix(site): Fix template icon field validation
BrunoQuaresma May 3, 2023
70dc4ae
Remove unecessary type
BrunoQuaresma May 3, 2023
1cb07fd
Merge branch 'main' into bq/fix-axios-error
BrunoQuaresma May 4, 2023
3e26793
Minor fixes
BrunoQuaresma May 4, 2023
2bbbb81
Fix user test
BrunoQuaresma May 4, 2023
6680924
Fix setup logic
BrunoQuaresma May 4, 2023
7ea15a3
Refactor edit group
BrunoQuaresma May 4, 2023
3fcaabf
Refactor create group page
BrunoQuaresma May 4, 2023
8288308
Fix
BrunoQuaresma May 4, 2023
da6c6a5
Fix stories
BrunoQuaresma May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix stories
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 4, 2023
commit da6c6a5cb98550b88e81e4a15b3186f136e65ee3
15 changes: 4 additions & 11 deletions site/src/components/CreateUserForm/CreateUserForm.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { action } from "@storybook/addon-actions"
import { Story } from "@storybook/react"
import { CreateUserForm, CreateUserFormProps } from "./CreateUserForm"
import { mockApiError } from "testHelpers/entities"

export default {
title: "components/CreateUserForm",
Expand All @@ -18,22 +19,14 @@ Ready.args = {
isLoading: false,
}

export const UnknownError = Template.bind({})
UnknownError.args = {
onCancel: action("cancel"),
onSubmit: action("submit"),
isLoading: false,
error: "Something went wrong",
}

export const FormError = Template.bind({})
FormError.args = {
onCancel: action("cancel"),
onSubmit: action("submit"),
isLoading: false,
formErrors: {
username: "Username taken",
},
error: mockApiError({
validations: [{ field: "username", detail: "Username taken" }],
}),
}

export const Loading = Template.bind({})
Expand Down
21 changes: 9 additions & 12 deletions site/src/pages/UsersPage/UsersPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
MockUser,
MockUser2,
MockAssignableSiteRoles,
mockApiError,
} from "testHelpers/entities"
import { UsersPageView, UsersPageViewProps } from "./UsersPageView"

Expand Down Expand Up @@ -42,17 +43,13 @@ EmptyPage.args = { users: [], isNonInitialPage: true }
export const Error = Template.bind({})
Error.args = {
users: undefined,
error: {
response: {
data: {
message: "Invalid user search query.",
validations: [
{
field: "status",
detail: `Query param "status" has invalid value: "inactive" is not a valid user status`,
},
],
error: mockApiError({
message: "Invalid user search query.",
validations: [
{
field: "status",
detail: `Query param "status" has invalid value: "inactive" is not a valid user status`,
},
},
},
],
}),
}