Skip to content

chore: add workspaceProxy to helm chart #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

deansheather
Copy link
Member

No description provided.

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, just that one question


env:
- name: CODER_PRIMARY_ACCESS_URL
value: "https://dev.coder.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be hardcoded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test file, not the actual values.yaml file.

Co-authored-by: Ben Potter <ben@coder.com>
@deansheather deansheather merged commit 667d9a7 into main May 4, 2023
@deansheather deansheather deleted the dean/helm-workspace-proxy branch May 4, 2023 21:07
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants