added FE tests

coder · Kira-Pilot · May 5, 2023 · May 1, 2023 · May 1, 2023 · May 3, 2023
commit 8536b75b806d8f7d05c6f58002160aa6bbcc1b75
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateScheduleForm.tsx
@@ -353,6 +353,7 @@ export const TemplateScheduleForm: FC<TemplateScheduleForm> = ({
                 label="Time until cleanup (days)"
                 variant="outlined"
                 type="number"
+                aria-label="Failure Cleanup"
               />
             </FormFields>
           </FormSection>
@@ -388,6 +389,7 @@ export const TemplateScheduleForm: FC<TemplateScheduleForm> = ({
                 label="Time until cleanup (days)"
                 variant="outlined"
                 type="number"
+                aria-label="Inactivity Cleanup"
               />
             </FormFields>
           </FormSection>

diff --git a/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx b/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx
@@ -6,11 +6,11 @@ import { Language as FooterFormLanguage } from "components/FormFooter/FormFooter
 import {
   MockEntitlementsWithScheduling,
   MockTemplate,
-} from "../../../testHelpers/entities"
+} from "testHelpers/entities"
 import {
   renderWithTemplateSettingsLayout,
   waitForLoaderToBeRemoved,
-} from "../../../testHelpers/renderHelpers"
+} from "testHelpers/renderHelpers"
 import { getValidationSchema } from "./TemplateScheduleForm"
 import TemplateSchedulePage from "./TemplateSchedulePage"
 import i18next from "i18next"
@@ -20,6 +20,8 @@ const { t } = i18next
 const validFormValues = {
   default_ttl_ms: 1,
   max_ttl_ms: 2,
+  failure_ttl_ms: 7,
+  inactivity_ttl_ms: 180,
 }
 
 const renderTemplateSchedulePage = async () => {
@@ -33,9 +35,13 @@ const renderTemplateSchedulePage = async () => {
 const fillAndSubmitForm = async ({
   default_ttl_ms,
   max_ttl_ms,
+  failure_ttl_ms,
+  inactivity_ttl_ms,
 }: {
   default_ttl_ms: number
   max_ttl_ms: number
+  failure_ttl_ms: number
+  inactivity_ttl_ms: number
 }) => {
   const user = userEvent.setup()
   const defaultTtlLabel = t("defaultTtlLabel", { ns: "templateSettingsPage" })
@@ -48,6 +54,16 @@ const fillAndSubmitForm = async ({
   await user.clear(maxTtlField)
   await user.type(maxTtlField, max_ttl_ms.toString())
 
+  const failureTtlField = screen.getByRole("checkbox", {
+    name: /Failure Cleanup/i,
+  })
+  await user.type(failureTtlField, failure_ttl_ms.toString())
+
+  const inactivityTtlField = screen.getByRole("checkbox", {
+    name: /Inactivity Cleanup/i,
+  })
+  await user.type(inactivityTtlField, inactivity_ttl_ms.toString())
+
   const submitButton = await screen.findByText(
     FooterFormLanguage.defaultSubmitLabel,
   )
@@ -59,6 +75,9 @@ describe("TemplateSchedulePage", () => {
     jest
       .spyOn(API, "getEntitlements")
       .mockResolvedValue(MockEntitlementsWithScheduling)
+
+    // remove when https://github.com/coder/coder/milestone/19 is completed.
+    jest.spyOn(API, "getExperiments").mockResolvedValue(["workspace_actions"])
   })
 
   it("succeeds", async () => {
@@ -71,7 +90,7 @@ describe("TemplateSchedulePage", () => {
     await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1))
   })
 
-  test("ttl is converted to and from hours", async () => {
+  test("default and max ttl is converted to and from hours", async () => {
     await renderTemplateSchedulePage()
 
     jest.spyOn(API, "updateTemplateMeta").mockResolvedValueOnce({
@@ -92,7 +111,28 @@ describe("TemplateSchedulePage", () => {
     )
   })
 
-  it("allows a ttl of 7 days", () => {
+  test("failure and inactivity ttl converted to and from days", async () => {
+    await renderTemplateSchedulePage()
+
+    jest.spyOn(API, "updateTemplateMeta").mockResolvedValueOnce({
+      ...MockTemplate,
+      ...validFormValues,
+    })
+
+    await fillAndSubmitForm(validFormValues)
+    await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1))
+    await waitFor(() =>
+      expect(API.updateTemplateMeta).toBeCalledWith(
+        "test-template",
+        expect.objectContaining({
+          failure_ttl_ms: validFormValues.failure_ttl_ms * 86400000,
+          inactivity_ttl_ms: validFormValues.inactivity_ttl_ms * 86400000,
+        }),
+      ),
+    )
+  })
+
+  it("allows a default ttl of 7 days", () => {
     const values: UpdateTemplateMeta = {
       ...validFormValues,
       default_ttl_ms: 24 * 7,
@@ -101,7 +141,7 @@ describe("TemplateSchedulePage", () => {
     expect(validate).not.toThrowError()
   })
 
-  it("allows ttl of 0", () => {
+  it("allows default ttl of 0", () => {
     const values: UpdateTemplateMeta = {
       ...validFormValues,
       default_ttl_ms: 0,
@@ -110,7 +150,7 @@ describe("TemplateSchedulePage", () => {
     expect(validate).not.toThrowError()
   })
 
-  it("disallows a ttl of 7 days + 1 hour", () => {
+  it("disallows a default ttl of 7 days + 1 hour", () => {
     const values: UpdateTemplateMeta = {
       ...validFormValues,
       default_ttl_ms: 24 * 7 + 1,
@@ -120,4 +160,62 @@ describe("TemplateSchedulePage", () => {
       t("defaultTTLMaxError", { ns: "templateSettingsPage" }),
     )
   })
+
+  it("allows a failure ttl of 7 days", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      failure_ttl_ms: 86400000 * 7,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).not.toThrowError()
+  })
+
+  it("allows failure ttl of 0", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      failure_ttl_ms: 0,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).not.toThrowError()
+  })
+
+  it("disallows a negative failure ttl", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      failure_ttl_ms: -1,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).toThrowError(
+      "Failure cleanup days must not be less than 0.",
+    )
+  })
+
+  it("allows an inactivity ttl of 7 days", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      inactivity_ttl_ms: 86400000 * 7,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).not.toThrowError()
+  })
+
+  it("allows an inactivity ttl of 0", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      inactivity_ttl_ms: 0,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).not.toThrowError()
+  })
+
+  it("disallows a negative inactivity ttl", () => {
+    const values: UpdateTemplateMeta = {
+      ...validFormValues,
+      inactivity_ttl_ms: -1,
+    }
+    const validate = () => getValidationSchema().validateSync(values)
+    expect(validate).toThrowError(
+      "Inactivity cleanup days must not be less than 0.",
+    )
+  })
 })
diff --git a/.../src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePageView.stories.tsx b/.../src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePageView.stories.tsx
@@ -11,6 +11,7 @@ export default {
   component: TemplateSchedulePageView,
   args: {
     allowAdvancedScheduling: true,
+    allowWorkspaceActions: true,
     template: MockTemplate,
     onSubmit: action("onSubmit"),
     onCancel: action("cancel"),

diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -1343,7 +1343,7 @@ export const MockEntitlementsWithScheduling: TypesGen.Entitlements = {
   }),
 }
 
-export const MockExperiments: TypesGen.Experiment[] = []
+export const MockExperiments: TypesGen.Experiment[] = ["workspace_actions"]
 
 export const MockAuditLog: TypesGen.AuditLog = {
   id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",