test: Return early and avoid using nil handler #7411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
May 4, 2023
spikecurtis
reviewed
May 5, 2023
| // HTTP Server | ||
| // HTTP Server. We have to start this once to get the access URL to start | ||
| // the workspace proxy with. The workspace proxy has the handler, so the | ||
| // http server will start with a 503 until the proxy is started. |
There was a problem hiding this comment.
A strategy that avoids the mutex is to create a listener, then pass that to http.Serve()
l := net.Listen("tcp", "127.0.0.1:")
url := "http://" + l.Addr().String()
I guess it gets a bit more complex if we need TLS. Does the wsproxy care whether its TLS?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.