Skip to content

chore: update develop script to start in dev mode #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

chore: update develop script to start in dev mode #742

merged 1 commit into from
Mar 31, 2022

Conversation

presleyp
Copy link
Contributor

  • remove creation of first user
  • add dev mode flags

kylecarbs
kylecarbs approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title could be more descriptive of the changes, but that's minor.

Much needed fixes!

@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #742 (577f489) into main (6ab1a68) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   64.31%   64.18%   -0.13%     
==========================================
  Files         198      199       +1     
  Lines       11635    11826     +191     
  Branches       87       87              
==========================================
+ Hits         7483     7591     +108     
- Misses       3351     3416      +65     
- Partials      801      819      +18
Flag Coverage Δ
unittest-go- 63.28% <ø> (-0.35%) ⬇️
unittest-go-macos-latest 58.86% <ø> (-0.17%) ⬇️
unittest-go-ubuntu-latest 61.92% <ø> (-0.08%) ⬇️
unittest-go-windows-2022 58.03% <ø> (-0.28%) ⬇️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
coderd/database/db.go 55.17% <0.00%> (-13.80%) ⬇️
coderd/parameter/compute.go 74.07% <0.00%> (-4.45%) ⬇️
cli/ssh.go 38.88% <0.00%> (-4.45%) ⬇️
agent/conn.go 65.38% <0.00%> (-3.59%) ⬇️
agent/agent.go 67.30% <0.00%> (-1.09%) ⬇️
coderd/provisionerdaemons.go 63.06% <0.00%> (-1.02%) ⬇️
provisionerd/provisionerd.go 80.17% <0.00%> (-0.59%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
cli/start.go 65.74% <0.00%> (-0.42%) ⬇️
coderd/workspaceresources.go 59.34% <0.00%> (-0.38%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab1a68...577f489. Read the comment docs.

@presleyp presleyp changed the title chore: update develop script chore: update develop script to start in dev mode Mar 30, 2022
@presleyp presleyp merged commit b942c74 into main Mar 31, 2022
@presleyp presleyp deleted the presleyp/develop-script branch March 31, 2022 12:24
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@presleyp @kylecarbs @misskniss