Skip to content

feat(site): Show update confirmation dialog #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Preview:
Screen Shot 2023-05-04 at 15 14 37

Close #6989

@BrunoQuaresma BrunoQuaresma requested a review from a team May 4, 2023 18:15
@BrunoQuaresma BrunoQuaresma self-assigned this May 4, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team May 4, 2023 18:15
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 4, 2023 18:29
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -132,7 +134,7 @@ export const WorkspaceReadyPage = ({
handleStop={() => workspaceSend({ type: "STOP" })}
handleRestart={() => restartWorkspace(workspace)}
handleDelete={() => workspaceSend({ type: "ASK_DELETE" })}
handleUpdate={() => workspaceSend({ type: "UPDATE" })}
handleUpdate={() => setIsConfirmingUpdate(true)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!!! 👌

@BrunoQuaresma BrunoQuaresma merged commit 164146c into main May 4, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/confirm-update branch May 4, 2023 18:40
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-confirm workspace Update from the UI
2 participants