Skip to content

refactor(site): Update workspace header #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

refactor(site): Update workspace header #7433

merged 3 commits into from
May 5, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2023-05-05 at 10 41 45

After on large screen:
Screen Shot 2023-05-05 at 10 56 38

After on medium screen:
Screen Shot 2023-05-05 at 10 58 30

After on small screen:
Screen Shot 2023-05-05 at 11 01 31

@BrunoQuaresma BrunoQuaresma requested review from a team and rodrimaia and removed request for a team May 5, 2023 14:03
kylecarbs
kylecarbs approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic change. I didn't look at the code, but the UI is an awesome improvement.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 5, 2023 14:56
@BrunoQuaresma
Copy link
Collaborator Author

I set auto merge but feel free to raise comments, I can take care of them right after since tests and stories are all good!

@BrunoQuaresma BrunoQuaresma merged commit 3632ac8 into main May 5, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-header branch May 5, 2023 15:02
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@rodrimaia rodrimaia Awaiting requested review from rodrimaia rodrimaia was automatically assigned from coder/ts

@Kira-Pilot Kira-Pilot Awaiting requested review from Kira-Pilot

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @kylecarbs