chore: Allow editing proxy fields via api. #7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 5, 2023
enterprise/coderd/workspaceproxy.go
Outdated
Comment on lines
415
to
425
| // TODO: This audit log does not work because it has no user id | ||
| // associated with it. The audit log commitAudit() function ignores | ||
| // the audit log if there is no user id. We should find a solution | ||
| // to make sure this event is tracked. | ||
| //auditor = api.AGPL.Auditor.Load() | ||
| //aReq, commitAudit = audit.InitRequest[database.WorkspaceProxy](rw, &audit.RequestParams{ | ||
| // Audit: *auditor, | ||
| // Log: api.Logger, | ||
| // Request: r, | ||
| // Action: database.AuditActionWrite, | ||
| //}) |
There was a problem hiding this comment.
Going to kick fixing this to another PR.
I commented out rather than deleting it to remind us that we probably should audit log this, but at the moment we cannot.
sreya
approved these changes
May 9, 2023
|
Can you also edit the default proxy name and icon? (it's difficult for me to check since the slim builds don't include |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Adds cli command to edit workspace proxy fields.
Also add
coder wsproxy regenerate-token <name>to generate a new auth token for the wsproxyFixes #7406
Fixes #7407