Skip to content

chore(site): Upgrade to MUI v5 #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 10, 2023
Merged

chore(site): Upgrade to MUI v5 #7437

merged 36 commits into from
May 10, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this May 5, 2023
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 9, 2023 15:06
@Kira-Pilot
Copy link
Member

Screenshot 2023-05-10 at 10 23 02 AM

Seeing some of these errors when I load /workspaces

@Kira-Pilot
Copy link
Member

Tooltip styling looks a little bit different on dev.coder.com vs local:

dev.coder.com:
Screenshot 2023-05-10 at 10 26 52 AM

local:
Screenshot 2023-05-10 at 10 26 57 AM

@Kira-Pilot
Copy link
Member

Kira-Pilot commented May 10, 2023

The workspace buttons on your branch look a bit smaller than those on dev.coder.com but IDK if this is due to MUI or related to another change. Actually this seems like most buttons. Smaller cancel buttons on forms, as well.
Screenshot 2023-05-10 at 10 32 34 AM

@Kira-Pilot
Copy link
Member

Did we lose some terminal styling?
Screenshot 2023-05-10 at 10 35 10 AM

@Kira-Pilot
Copy link
Member

Looks like some large link text on local:
Screenshot 2023-05-10 at 10 36 34 AM

@Kira-Pilot
Copy link
Member

Some extra label padding on the workspace owner input, and also an example of the buttons looking a bit different.
Screenshot 2023-05-10 at 10 39 41 AM

@Kira-Pilot
Copy link
Member

Kira-Pilot commented May 10, 2023

Screenshot 2023-05-10 at 10 46 19 AM
I see this error on the license page. There are also some font size changes on that page.

@Kira-Pilot
Copy link
Member

Screenshot 2023-05-10 at 11 03 50 AM

I think we need to upgrade the calendar picker on the tokens page. It's not using the dark theme, and the functionality seems a little off.

@Kira-Pilot
Copy link
Member

Some minor stuff but overall this is looking fantastic and I am so excited about this change! Great work! 🥳

@Kira-Pilot
Copy link
Member

Screenshot 2023-05-10 at 11 11 43 AM
Unstyled input arrows

@BrunoQuaresma
Copy link
Collaborator Author

@Kira-Pilot Thanks A LOT, for this review. I'm going to comment as I'm going forward fixing the issues.

The workspace buttons on your branch look a bit smaller than those on dev.coder.com

Yes, we are changing the height sizes but I think they are looking ok. At some point, we can improve them by getting some inspiration from other design/component libraries.

Did we lose some terminal styling?

Maybe did you get some "asset loading" error? It is working as expected for me tho:
Screen Shot 2023-05-10 at 13 16 03

@BrunoQuaresma
Copy link
Collaborator Author

I can't see the errors on the license page, but I fixed the sizing!
Screen Shot 2023-05-10 at 13 43 43

@BrunoQuaresma
Copy link
Collaborator Author

I think we need to upgrade the calendar picker on the tokens page. It's not using the dark theme, and the functionality seems a little off.

I didn't find the calendar component. For, me it shows a set of date ranges.

Screen Shot 2023-05-10 at 13 47 12

@BrunoQuaresma
Copy link
Collaborator Author

Unstyled input arrows

I was not able to find the cause of this "missing style" but I will do it later when getting the colors in the right place. Sounds good?

@Kira-Pilot
Copy link
Member

I didn't find the calendar component. For, me it shows a set of date ranges.

@BrunoQuaresma you need to select the "Custom" date range to see the calendar picker - it shows up for that option, only. Let me know if you're still having trouble!

@BrunoQuaresma
Copy link
Collaborator Author

@Kira-Pilot the number controls and date picker are fixed! They were the same issue.

Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 10, 2023 19:39
@BrunoQuaresma BrunoQuaresma merged commit 816c37d into main May 10, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/migrate-to-muiv5 branch May 10, 2023 19:42
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants