Skip to content

chore(site): Add type checking #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2023
Merged

chore(site): Add type checking #7441

merged 5 commits into from
May 5, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

I noticed a few type errors on the main and I found out that Vite does not run any type checking during the build so I added it.

@BrunoQuaresma BrunoQuaresma requested a review from a team May 5, 2023 18:53
@BrunoQuaresma BrunoQuaresma self-assigned this May 5, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team May 5, 2023 18:53
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 5, 2023 18:53
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coooool. I was looking at getting some time to fix this for a while. It was even on my todolist =D
image

thank you

@BrunoQuaresma BrunoQuaresma merged commit 643a9ef into main May 5, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/add-type-checking branch May 5, 2023 21:46
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants