Skip to content

feat: add workspace actions cleanup configuration flags to CLI template create and edit #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves #7419

Flagged and featured:
Screenshot 2023-05-08 at 12 10 28 PM

@Kira-Pilot Kira-Pilot changed the title feat (cli): add workspace actions cleanup configuration flags to template create and edit feat: add workspace actions cleanup configuration flags to template create and edit May 8, 2023
@Kira-Pilot Kira-Pilot changed the title feat: add workspace actions cleanup configuration flags to template create and edit feat: add workspace actions cleanup configuration flags to CLI template create and edit May 8, 2023
@Kira-Pilot Kira-Pilot added this to the Workspace Actions GA milestone May 8, 2023
@Kira-Pilot Kira-Pilot requested review from sreya and Emyrk May 8, 2023 19:14
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment. We should pull the entitlement (and maybe experiment check) into a helper func

@Kira-Pilot Kira-Pilot merged commit a42a36a into main May 10, 2023
@Kira-Pilot Kira-Pilot deleted the cleanup-ttl-cl/kira-pilot branch May 10, 2023 19:57
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace actions: add new cleanup ttl flag to CLI for template create and template edit
2 participants